[BITAU-139] Add Menu Item to Turn on Authenticator Sync #1048
+164
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brant-livefront
requested review from
matt-livefront,
phil-livefront,
victor-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1048 +/- ##
=======================================
Coverage 89.29% 89.30%
=======================================
Files 670 670
Lines 42056 42093 +37
=======================================
+ Hits 37553 37590 +37
Misses 4503 4503 ☔ View full report in Codecov by Sentry. |
victor-livefront
previously approved these changes
Oct 16, 2024
BitwardenShared/UI/Platform/Settings/Settings/AccountSecurity/AccountSecurityViewTests.swift
Show resolved
Hide resolved
fedemkr
reviewed
Oct 17, 2024
Comment on lines
171
to
173
| state.isAuthenticatorSyncEnabled = try await services.stateService.getSyncToAuthenticator() | ||
| state.shouldShowAuthenticatorSyncSection = | ||
| await services.configService.getFeatureFlag(.enableAuthenticatorSync) |
There was a problem hiding this comment.
🎨 Even though it may be a little, we can improve the performance of loading this if the feature flag is off then we don't need to call try await services.stateService.getSyncToAuthenticator(); so:
Suggested change
| state.isAuthenticatorSyncEnabled = try await services.stateService.getSyncToAuthenticator() | |
| state.shouldShowAuthenticatorSyncSection = | |
| await services.configService.getFeatureFlag(.enableAuthenticatorSync) | |
| state.shouldShowAuthenticatorSyncSection = | |
| await services.configService.getFeatureFlag(.enableAuthenticatorSync) | |
| if state.shouldShowAuthenticatorSyncSection { | |
| state.isAuthenticatorSyncEnabled = try await services.stateService.getSyncToAuthenticator() | |
| } |
There was a problem hiding this comment.
👍 Good optimization. Added that in the latest commit.
fedemkr
approved these changes
Oct 17, 2024
brant-livefront
deleted the
brant/BITAU-139-add-menu-item-to-turn-on-authenticator-sync
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BITAU-139
📔 Objective
This PR adds a section to the Settings -> Account Security screen that includes a toggle to turn the sync with Authenticator. This is hidden behind the feature flag. Therefore, it should not affect this view in any way unless the feature flag is turned on. When it's turned on, you can use this to turn on sync for the current account (which will kick off the syncing process).
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes